chore(pluginutils): remove unused peer dependency#1983
Conversation
`@rollup/pluginutils` declares a peer dependency on `rollup`. However, it doesn’t actually use this dependency anywhere. Refs mdx-js/mdx#2671
|
@CharlieHelps please do a thorough review of this PR to determine if it's ready to merge. Look at the diff, reviews, comments, and referenced issues/docs/links to build a complete understanding. Then respond with a comment that includes a list of MUST fix items that must be fixed before the the PR is merged, and a list of IMPROVEMENTS that shouldn't block the merge but may be quick improvements or things that could be addressed in a follow up PR. The MUST fix items should explain exactly what's wrong and what needs to change to resolve the problem. Both should be numbered lists and the IMPROVEMENTS list should continue counting up from the MUST list. It's OK if there are no IMPROVEMENTS or MUST fix items, you can just omit the lists. |
|
I did a full review of the diff, existing PR comments/reviews, and the referenced issue (mdx-js/mdx#2671). MUST fix
|
|
@remcohaszing thanks for the PR. while it might be attractive to use the pluginutils package outside of rollup, the peerDep here matches dep enforcement with other plugins/packages in the repo, and enforces a contract. We're going to decline this PR for the moment. |
Rollup Plugin Name:
@rollup/pluginutilsThis PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
refs mdx-js/mdx#2671
Description
@rollup/pluginutilsdeclares a peer dependency onrollup. However, it doesn’t actually use this dependency anywhere.